[Kde-pim] Review Request: Add zoom in/out buttons to KMail reader.

[Martin Hignett]

> On 2009-12-29 06:53:09, Torgny Nyblom wrote:
> > Hi,
> > 
> > Could you please rework this patch against the akonadi-ports branch? KMail trunk is currently feature frozen. This will probably require some changes as the messageviewer component has changed in that branch (from using KHTML to [KDE|Qt]WebKit for rendering).

No problem, but it might take me a day or so to get a new patch ready - I'm having troubles building the akonadi-ports branch.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2456/#review3521
-----------------------------------------------------------


On 2009-12-28 21:37:36, Martin Hignett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2456/
> -----------------------------------------------------------
> 
> (Updated 2009-12-28 21:37:36)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Provides a zoom in/out button, context menu and shortcuts (the + and - keys on the numeric keypad) for the KMail reader.
> I'm not sure how to add the toolbar buttons to the default toolbar, but when they are added, this works.
> 
> 
> This addresses bug 59576.
>     https://bugs.kde.org/show_bug.cgi?id=59576
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1067045 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1067045 
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.h 1067045 
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.cpp 1067045 
> 
> Diff: http://reviewboard.kde.org/r/2456/diff
> 
> 
> Testing
> -------
> 
> Tested that + and - keys, context menu and toolbar buttons work.
> Tested that the zoom has sensible minimum and maximum bounds beyond which it won't go (these match the bounds defined in KHTMLPart).
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/