[Kde-pim] Review Request: Allow building with -DQT_NO_CAST_FROM_ASCII

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2423/#review3468
-----------------------------------------------------------

Ship it!


Does that mean all of kdepim builds with -DQT_NO_CAST_FROM_ASCII now? If so, then I suggest we make this the default by changing the top-level CMakeLists.txt file.

- Thomas


On 2009-12-19 20:06:54, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2423/
> -----------------------------------------------------------
> 
> (Updated 2009-12-19 20:06:54)
> 
> 
> Review request for KDE PIM and Bertjan Broeksema.
> 
> 
> Summary
> -------
> 
> Replaces implicit ByteArray to QString conversion with explicit QString::fromAscii(), QLatin1String for const char* literals, QString::fromLocal8Bit() for encoded filenames.
> 
> No idea whether mbox files are always ASCII, maybe one of the other "from" methods is more appropriate
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/mbox.cpp 1063995 
>   /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/tests/mboxbenchmark.cpp 1063995 
>   /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/tests/mboxtest.cpp 1063995 
> 
> Diff: http://reviewboard.kde.org/r/2423/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/