[Kde-pim] Review Request: ktexteditorkabcbridge.cpp:29: warning: 'void ktexteditorkabcbridge_run_kaddressbook()' defined but not used

[Guy Maurel]

> On 2009-12-15 16:53:12, Thomas McGuire wrote:
> > Just remove the function instead of commenting it out, then commit.

somebody (tokoe or coles) has already done the change, without looking my request!


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2151/#review3427
-----------------------------------------------------------


On 2009-11-12 18:10:20, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2151/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 18:10:20)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/plugins/ktexteditor/ktexteditorkabcbridge.cpp:29: warning: 'void ktexteditorkabcbridge_run_kaddressbook()' defined but not used
> 
> my proposal: as this functions is not defined in the ktexteditorkabcbridge.h, comment it out, until someone needs it.
> see: ktexteditorkabcbridge-gm-62.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/plugins/ktexteditor/ktexteditorkabcbridge.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2151/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/