[Kde-pim] Review Request: keylistsortfilterproxymodel.cpp:58: warning: unused parameter 'other'

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2243/#review3486
-----------------------------------------------------------


Same #warning issue again.

The original warning here might actually indicate a bug, since the copy constructor doesn't use the other object. Again, this needs an understanding of the code to be fixed properly.


/trunk/KDE/kdepim/kleopatra/models/keylistsortfilterproxymodel.cpp
<http://reviewboard.kde.org/r/2243/#comment2790>

    This TODO is wrong, the function doesn't need any code, everything is done in the initalization list here.
    
    Please don't add all these TODO comments


- Thomas


On 2009-11-20 18:25:45, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2243/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 18:25:45)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/models/keylistsortfilterproxymodel.cpp:58: warning: unused parameter 'other'
> 
> at
> AbstractKeyListSortFilterProxyModel::AbstractKeyListSortFilterProxyModel
> 
> my proposal: add Q_UNUSED( )
> see: keylistsortfilterproxymodel-gm-102.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/models/keylistsortfilterproxymodel.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2243/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/