[Kde-pim] Review Request: Add additional parameter to EntityTreeModel::entityData()

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2392/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

In KAlarm, when it overrides EntityTreeModel::entityData(const Item&, ...), it needs to know which collection the Item belongs to. Currently this is not easily available, so I propose to add a 'const QModelIndex&' parameter to the method signature to enable the Item to be located in the model. This involves no extra overhead and saves a lot of extra unnecessary processing. Being a virtual method, this needs to be done before KDE 4.4 is finalised.

I haven't added a similar parameter to EntityTreeModel::entityData(const Collection&, ...) since there isn't such an obvious reason to add it, but it might make sense to do this as well to make them similar.

Obviously, other references to the method in kdepim or other KDE modules will also need to be changed if this is approved, but I haven't included them in this diff.


Diffs
-----

  trunk/KDE/kdepimlibs/akonadi/contact/contactcompletionmodel.cpp 1057518 
  trunk/KDE/kdepimlibs/akonadi/contact/contactcompletionmodel_p.h 1057518 
  trunk/KDE/kdepimlibs/akonadi/entitytreemodel.h 1063028 
  trunk/KDE/kdepimlibs/akonadi/entitytreemodel.cpp 1063028 

Diff: http://reviewboard.kde.org/r/2392/diff


Testing
-------


Thanks,

David

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/