[Kde-pim] Review Request: Allow building with -DQT_NO_CAST_FROM_ASCII

Kevin Krammer kevin.krammer at gmx.at
Sat Dec 19 16:15:21 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2423/
-----------------------------------------------------------

Review request for KDE PIM and Bertjan Broeksema.


Summary
-------

Replaces implicit ByteArray to QString conversion with explicit QString::fromAscii(), QLatin1String for const char* literals, QString::fromLocal8Bit() for encoded filenames.

No idea whether mbox files are always ASCII, maybe one of the other "from" methods is more appropriate


Diffs
-----

  /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/tests/mboxbenchmark.cpp 1063924 
  /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/tests/mboxtest.cpp 1063924 
  /trunk/KDE/kdepim/runtime/resources/mbox/libmbox/mbox.cpp 1063924 

Diff: http://reviewboard.kde.org/r/2423/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list