[Kde-pim] Review Request: ktexteditorkabcbridge.cpp:29: warning: 'void ktexteditorkabcbridge_run_kaddressbook()' defined but not used

Guy Maurel guy.j at maurel.de
Fri Dec 18 17:22:10 GMT 2009


Hello!
On Wednesday 16 December 2009 19:18:00 Tobias Koenig wrote:
> On Wed, Dec 16, 2009 at 05:10:47PM -0000, Guy Maurel wrote:
> Hej Guy,
> 
> > > On 2009-12-15 16:53:12, Thomas McGuire wrote:
> > > > Just remove the function instead of commenting it out, then commit.
> >
> > somebody (tokoe or coles) has already done the change, without looking my
> > request!
> 
> The code used deprecated methods (KABC::StdAddressBook::whoAmI), so I
>  ported it to the new methods and removed the commented code in that commit
It's OK... and your solution is a better one

guy
-- 
guy-kde
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list