[Kde-pim] Review Request: keylistcontroller.cpp:346: warning: unused parameter 'idx

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2248/#review3460
-----------------------------------------------------------



/trunk/KDE/kdepim/kleopatra/view/keylistcontroller.cpp
<http://reviewboard.kde.org/r/2248/#comment2763>

    Replacing one warning with another warning doesn't achive much :)
    
    As for the use of the parameters. see the connect() statement in KeyListController::Private::connectView() that connects to those two functions here.
    
    You'll see the parameters come from QAbstractItemView, read the documentation what they do. In this case, they seem to be really not necessary, so we can either use Q_UNUSED or just remove the parameters from the slots altogether (connecting a signal that has more parameters than the slot is allowed)


- Thomas


On 2009-11-20 18:58:23, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2248/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 18:58:23)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/view/keylistcontroller.cpp:346: warning: unused parameter 'idx'
> /.../kdepim/kleopatra/view/keylistcontroller.cpp:353: warning: unused parameter 'new_'
> /.../kdepim/kleopatra/view/keylistcontroller.cpp:353: warning: unused parameter 'old'
> 
> at
> KeyListController::Private::slotSelectionChanged
> 
> my proposal: add some Q_UNUSED( )
> see: keylistcontroller-gm-107.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/view/keylistcontroller.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2248/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/