[Kde-pim] Review Request: kmail goes on without sense

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2359/#review3495
-----------------------------------------------------------


This problem can happen with all KDE applications, right?
I think that this should be handled in kdelibs instead. Also I think an messagebox to inform the user would be better, as otherwise KMail quites without any apparent reason when not run from the command line.

- Thomas


On 2009-12-11 18:17:23, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2359/
> -----------------------------------------------------------
> 
> (Updated 2009-12-11 18:17:23)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The file "kmmainwin.rc" should be installed at some place such as /usr/local/share/apps/kmail/
> But if the file is missing, kmail goes on without sense.
> If it is started from a command line, one get a warning. I think a warning is not enought.
> 
> my proposal: Check if the file is present, else give an error and stop kmail until the administrator
> has installed/corrected the missed file.
> 
> see: kmmainwin-gm-102.diff screenshot
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwin.cpp 1059891 
> 
> Diff: http://reviewboard.kde.org/r/2359/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/2359/s/276/
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/