[Kde-pim] Review Request: echocommand.cpp:166: warning: suggest parentheses around && within ||, echocommand.cpp:166: warning: suggest parentheses around && within ||

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2143/#review3492
-----------------------------------------------------------

Ship it!


Ok, please commit after fixing the coding style.


/trunk/KDE/kdepim/kleopatra/uiserver/echocommand.cpp
<http://reviewboard.kde.org/r/2143/#comment2791>

    Add spaces to the inside of the parenthesis to conform with the KDEPIM coding style.


- Thomas


On 2009-11-12 14:08:37, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2143/
> -----------------------------------------------------------
> 
> (Updated 2009-11-12 14:08:37)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kleopatra/uiserver/echocommand.cpp:166: warning: suggest parentheses around && within ||
> 
> at
> EchoCommand::slotInputReadyRead
> 
> /.../kdepim/kleopatra/uiserver/echocommand.cpp:166: warning: suggest parentheses around && within ||
> 
> at
> EchoCommand::doStart
> 
> 
> my proposal: complete with some more parentheses
> see: echocommand-gm-54.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/uiserver/echocommand.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2143/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/