[Kde-pim] Review Request: KDGanttSemiSizingControl.cpp:317: warning: suggest parentheses around && within ||

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2160/#review3490
-----------------------------------------------------------

Ship it!


Looks ok, please commit.

- Thomas


On 2009-11-13 17:42:05, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2160/
> -----------------------------------------------------------
> 
> (Updated 2009-11-13 17:42:05)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdepim
> reports:
> /.../kdepim/kdgantt1/KDGanttSemiSizingControl.cpp:317: warning: suggest parentheses around && within ||
> /.../kdepim/kdgantt1/KDGanttSemiSizingControl.cpp:324: warning: suggest parentheses around && within ||
> 
> at
> KDGanttSemiSizingControl::setup
> 
> my proposal: complete with some more parentheses
> see: KDGanttSemiSizingControl-gm-63.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kdgantt1/KDGanttSemiSizingControl.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2160/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/