[Kde-pim] Review Request: Leaks in Kcal

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2383/#review3432
-----------------------------------------------------------



trunk/KDE/kdepimlibs/kcal/icalformat.h
<http://reviewboard.kde.org/r/2383/#comment2751>

    A better wording (and spelling) would be
    
    "It is the responsibility of the caller to free the object returned".



trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp
<http://reviewboard.kde.org/r/2383/#comment2750>

    AFAICS, this is wrong. My reading of the libical code is that "p" assumes ownership of "attach" when icalproperty_new_attach() is called, so that "attach" will be freed when "p" is freed.
    
    If it actually is correct, there are also other places in icalformat_p.cpp which should be changed in the same way.


- David


On 2009-12-16 08:14:18, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2383/
> -----------------------------------------------------------
> 
> (Updated 2009-12-16 08:14:18)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> A couple of leaks found in kcal. 
> 
> Also a misleading documentation leads to another leak.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/icalformat.h 1062817 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1062817 
>   trunk/KDE/kdepimlibs/kcal/vcalformat.cpp 1062817 
> 
> Diff: http://reviewboard.kde.org/r/2383/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/