[Kde-pim] Review Request: add the "Open With ..." button to the attachment handling dialog

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1219/#review1906
-----------------------------------------------------------

Ship it!


Ok, commit it.

I'm still not very happy about the fact that the don't ask again handling is done manually, but ok.

Oh and yes, Konqueror + reviewboard sucks :(

- Thomas


On 2009-08-05 13:19:04, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1219/
> -----------------------------------------------------------
> 
> (Updated 2009-08-05 13:19:04)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> According to https://bugs.kde.org/show_bug.cgi?id=201374
> add the "Open With ..." button to the attachment handling dialog even when KDE found a matching application
> to open the attachment with.
> 
> 
> This addresses bug 201374.
>     https://bugs.kde.org/show_bug.cgi?id=201374
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 1005628 
>   /trunk/KDE/kdepim/kmail/attachmentdialog.h PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/attachmentdialog.cpp PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1005719 
> 
> Diff: http://reviewboard.kde.org/r/1219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/