[Kde-pim] Review Request: Allow setting of arbitrary environment variables in the Akonadi testrunner

igorto igor_trindade at yahoo.com.br
Thu Aug 27 16:54:46 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1420/#review2163
-----------------------------------------------------------

Ship it!


For me look likes good without any big modifications.

- igorto


On 2009-08-27 13:00:54, Constantin Berzan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1420/
> -----------------------------------------------------------
> 
> (Updated 2009-08-27 13:00:54)
> 
> 
> Review request for KDE PIM, Volker Krause and igorto.
> 
> 
> Summary
> -------
> 
> The testrunner currently sets up a clean environment for tests to run, and exported envvars are not propagated to the test environment.
> This change allows setting arbitrary envvars in the test's config file like this:
> <config>
>   ...
>   <envvar name="AKONADI_DISABLE_AGENT_AUTOSTART">true</envvar>
> </config>
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/tests/testrunner/config.h 1013501 
>   /trunk/KDE/kdepimlibs/akonadi/tests/testrunner/config.cpp 1013501 
>   /trunk/KDE/kdepimlibs/akonadi/tests/testrunner/setup.cpp 1013501 
> 
> Diff: http://reviewboard.kde.org/r/1420/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Constantin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list