[Kde-pim] Review Request: KMail: Moved icons and sender/receiver column settings from General to View tab in the folder properties dialog.

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1383/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Straight forward patch to move icons and sender/receiver column settings from General to View tab in the folder properties dialog.
This was made as suggested by Thomas McGuire in review 1325(http://reviewboard.kde.org/r/1325/).

I disagree with moving the name setting as suggested. I think it would be confusing. Almost every folder properties dialog in every other program has that on the General tab. See Dolphin for example.


Diffs
-----

  /trunk/KDE/kdepim/kmail/kmfolderdialog.h 1013760 
  /trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 1013760 

Diff: http://reviewboard.kde.org/r/1383/diff


Testing
-------


Screenshots
-----------

Folder Properties Dialog, View Tab
  http://reviewboard.kde.org/r/1383/s/184/


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/