[Kde-pim] Review Request: KMail: Added per-folder aggregation and theme message list settings to folder dialog.

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1325/
-----------------------------------------------------------

(Updated 2009-08-17 15:56:18.770850)


Review request for KDE PIM.


Changes
-------

Added messagelistview/core/AggregationComboBox.
Added messagelistview/core/AggregationCommitButton.
Added messagelistview/core/ThemeComboBox.
Added messagelistview/core/ThemeCommitButton.
Modified ConfigureDialog and KMFolderDialog to use AggregationComboBox, AggregationCommitButton, ThemeComboBox, and ThemeCommitButton in order to reduce code duplication between both dialogs.
Added View tab to folder properties dialog that contains message list settings.


Summary
-------

Added folder specific aggregation and theme message list settings to the folder properties dialog.

The way the folder dialog message list default options are applied, functions differently from the existing context menus. When deselecting "Folder Always Uses This ..." in the context menus, the default option is over written with, what was, that folder's private option. This makes sense because of the limited atomic design of context menus.

The message list settings that I added to the folder dialog keeps all changes local to that dialog's folder. Checking the "Use default ..." checkbox and clicking the Ok button applies the default options as viewed in Settings->Configure KMail->Appearance->Message List.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/CMakeLists.txt 1012391 
  /trunk/KDE/kdepim/kmail/configuredialog.cpp 1012391 
  /trunk/KDE/kdepim/kmail/configuredialog_p.h 1012391 
  /trunk/KDE/kdepim/kmail/kmfolderdialog.h 1012391 
  /trunk/KDE/kdepim/kmail/kmfolderdialog.cpp 1012391 
  /trunk/KDE/kdepim/kmail/messagelistview/core/aggregationcombobox.h PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/aggregationcombobox.cpp PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/aggregationconfigbutton.h PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/aggregationconfigbutton.cpp PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themecombobox.h PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themecombobox.cpp PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themeconfigbutton.h PRE-CREATION 
  /trunk/KDE/kdepim/kmail/messagelistview/core/themeconfigbutton.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1325/diff


Testing
-------


Screenshots
-----------

Folder Properties Dialog
  http://reviewboard.kde.org/r/1325/s/180/
Folder Properties Dialog, View Tab
  http://reviewboard.kde.org/r/1325/s/182/


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/