[Kde-pim] assert in ImapAccountBase::makeConnection()

[Thomas McGuire]

Hi,

On Wednesday 05 August 2009 19:46:43 you wrote:
> while testing different bko issues with current trunk in kmail,
> I hit the assert
>   Q_ASSERT( !mSlave ); // disconnected on 'wrong login' error already, or
> first try in imapaccountbase.cpp line 309
>
> The situation is: I did not enter a username nor a password and click OK.
>
> Should this assert really be triggered in this situation ? I don't think
> so. What shall it really be ?

I'm not aware of the details of the code, but I think if there is no 
connection to the server, there should be no slave, and that is what the 
assert checks for.
I think empty user+password is ok, since some IMAP servers of ISPs 
authenticate on the IP address only (or something else, no idea how it works).

So I think there shouldn't be a slave anymore when the connection fails.

But I could be completely wrong and the bug is somewhere.

Of course it shouldn't crash :)

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090805/0d23fd9b/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/