[Kde-pim] Review Request: Convert AkonadiSetupWidget to the new EntityTreeModel/View Classes

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1122/#review1891
-----------------------------------------------------------


Looks okay to me. Please fix the cancel issue and feel free to commit afterwards. About the filtering, I guess that's broken in the current code also?!

- Bertjan


On 2009-08-03 01:03:14, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1122/
> -----------------------------------------------------------
> 
> (Updated 2009-08-03 01:03:14)
> 
> 
> Review request for KDE PIM, Volker Krause, Stephen Kelly, and Bertjan Broeksema.
> 
> 
> Summary
> -------
> 
> This patch converts kpilot's Akonadi setup widget to use the EntityTreeModel and EntityTreeView class.  One benefit of this is that we can use the EntityTreeViewStateSaver class to preserve the selected collection information.  
> 
> There does seem to be a slight bug . . . restoring the state only happens after you click on the TreeViewWidget (for instance, on the scrollbar).  I don't know if this is a bug in my code or in the EntityTreeView stuff.  Other than that, things seem to work. 
> 
> Also, mime type handling seems to be broken.  I have to add the inode/directory mimetype to get calendars to show up.  Nothing shows up in the contacts conduit config.  A possible solution is to set allMimeTypesMonitored in the monitor and use some kind of proxy model to filter only the types that we really need.  
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kpilot/conduits/todo/todoconfig.cc 1005960 
>   trunk/KDE/kdepim/kpilot/conduits/calendar/calendarconfig.cc 1005960 
>   trunk/KDE/kdepim/kpilot/conduits/contacts/contactsconfig.cc 1005960 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.h 1005960 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc 1005960 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/CMakeLists.txt 1005960 
> 
> Diff: http://reviewboard.kde.org/r/1122/diff
> 
> 
> Testing
> -------
> 
> Compiled, Opened settings dialog, selected a calendar, closed the dialog, opened it again.  Calendar is still selected.
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/