[Kde-pim] Review Request: Expandable/Collapsible "To" and "Cc" fields in KMail
Allen Winter
winter at kde.org
Mon Aug 31 13:23:42 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1492/#review2220
-----------------------------------------------------------
hey, that's sorta cool.
I only looked at the screenshots so far, but I like it.
Not sure this should be implemented for the more basic header styles, but it might fight well with the fancy style.
- Allen
On 2009-08-31 11:19:09, Torgny Nyblom wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1492/
> -----------------------------------------------------------
>
> (Updated 2009-08-31 11:19:09)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Makes the "To" and "Cc" fields collapsible if more then three addresses are present in the respective field.
> Image is borrowed from the same function for attachments, but code is slightly different.
>
> As of now this is just enabled for "Fancy headers" but the concept is easily expanded into all kinds of header styles.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/kmail/headerstyle.cpp 1017748
> /trunk/KDE/kdepim/kmail/kmreaderwin.h 1017748
> /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1017748
> /trunk/KDE/kdepim/kmail/stringutil.h 1017748
> /trunk/KDE/kdepim/kmail/stringutil.cpp 1017748
> /trunk/KDE/kdepim/kmail/urlhandlermanager.cpp 1017748
>
> Diff: http://reviewboard.kde.org/r/1492/diff
>
>
> Testing
> -------
>
> Built, opened test email in diffent header styles and expanded/collapsed the headers.
>
>
> Screenshots
> -----------
>
> Collapsed
> http://reviewboard.kde.org/r/1492/s/195/
> One expanded, one collapsed
> http://reviewboard.kde.org/r/1492/s/196/
> Expanded
> http://reviewboard.kde.org/r/1492/s/197/
>
>
> Thanks,
>
> Torgny
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list