[Kde-pim] decodeRFC2047String

[Ingo Klöcker]

On Sunday 23 August 2009, Martin Koller wrote:
> On Sunday 23 August 2009, Ingo Klöcker wrote:
> > BTW, there is another minor error in
> > AddresseeLineEdit::dropEvent(). If the dropped URL is not a mailto
> > URL then still a comma is appended to the content of the line edit.
> > The lines
> >   if ( !contents.isEmpty() ) {
> >     contents.append( ", " );
> >   }
> > should be moved just before the above line appending the dropped
> > address.
>
> I changed the "append".
>
> For the rest of your comments, I understood that there would only be
> a need for a change if one would change decodeRFC2047(), right ?

Not really. Using KUrl::fromPercentEncoding() is superfluous in any 
case. So the patch can be reduced to
-          contents.append( (*it).path() );
+          contents.append( KMime::decodeRFC2047String( 
(*it).path().toUtf8() ) );

BTW, discussing the patch would be much easier if it were on Review 
Board (even if it seems to be overkill for such a short patch). ;-)


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090824/111ca79d/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/