[Kde-pim] Review Request: Add capability to merge items containing multiple parts, and to know what parts are available for a given item.

[Stephen Kelly]

Stephen Kelly wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1365/
> -----------------------------------------------------------
> 
> (Updated 2009-08-21 15:04:33.620721)
> 
> 
> Review request for KDE PIM.
> 
> 
> Changes
> -------
> 
> Changes:
> * Fix whitespace issues, ( foo ) instead of (foo).
> * Add some missing @since
> * Fix explicit
> * Change how the model and the PartFetcher interact. The PartFetcher now
> runs the item fetch job itself instead of requesting that the model
> execute the job using hacks with data/setData.
>     The partfetcher fetches the part and then sets it on the model so that
>     it's cached there.
> 
> The dynamic_cast is not changed to qobject_cast because the plugin object
> has already been cast to the ItemSerializerPlugin interface, so it is not
> a QObject. The dynamic_cast is safe anyway as it does not cross library
> boundaries.

Diff between old and new attached for the convenience of people who read the 
old one.

Steve.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1v2changes.patch
Type: text/x-patch
Size: 11140 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090821/323d1412/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/