[Kde-pim] Review Request: synchronize checkbox of the message window menu entry "Use Fixed Font".

Thomas McGuire mcguire at kde.org
Fri Aug 14 01:11:44 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1296/#review2019
-----------------------------------------------------------

Ship it!


Looks good, please commit.
Thanks for the patch.


/trunk/KDE/kdepim/kmail/kmreaderwin.cpp
<http://reviewboard.kde.org/r/1296/#comment1349>

    Coding style: Please use 2 spaces for indentation only.


- Thomas


On 2009-08-13 08:22:15, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1296/
> -----------------------------------------------------------
> 
> (Updated 2009-08-13 08:22:15)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the first step to fix bug 156653. Make the menu entry "Use Fixed Font" follow what the reader win is doing.
> 
> 
> This addresses bug 156653.
>     https://bugs.kde.org/show_bug.cgi?id=156653
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1010474 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1010474 
> 
> Diff: http://reviewboard.kde.org/r/1296/diff
> 
> 
> Testing
> -------
> 
> Before the patch, selecting the global menu "Use Fixed Font" and then opening a window to show the message, the checkbox of the menu entry in the window was reversed. After applying the patch, both are synchronized.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list