[Kde-pim] Review Request: header of columns for flag icons shall display the icon, not text

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1334/#review2045
-----------------------------------------------------------

Ship it!


Good idea about the icons.
That problem is the same as http://techbase.kde.org/Projects/PIM/KMail_Junior_Jobs#Better_handling_of_empty_column_titles_in_the_message_list, actually, but I like your solution better.

However, what happens when the user manually creates a column in a new theme that has only an icon in it, in this case it won't work, right?
In any case, this should be committed.

- Thomas


On 2009-08-16 13:46:05, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1334/
> -----------------------------------------------------------
> 
> (Updated 2009-08-16 13:46:05)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The text from the bug issue describes that:
> 
> Some of the columns that can be shown in the message list panel have icons in
> their contents (attachments, important, spam/not spam, and others). These
> columns are normally displayed with only the necessary width to the icons to be
> shown. Because of that, their headers can not be read/identified if they are
> texts (only the first one or two letters are shown). The headers of such
> columns should be icons, as they were in KMail from KDE 4.1.4 and KDE 3.5.x.
> This is a regression.
> 
> If an icon is set, only the icon (no text) will be shown.
> The implementation shows a tooltip for the columns which only show an icon.
> 
> 
> This addresses bug 183517.
>     https://bugs.kde.org/show_bug.cgi?id=183517
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/messagelistview/core/manager.cpp 1011896 
>   trunk/KDE/kdepim/kmail/messagelistview/core/model.cpp 1011896 
>   trunk/KDE/kdepim/kmail/messagelistview/core/theme.h 1011896 
>   trunk/KDE/kdepim/kmail/messagelistview/core/theme.cpp 1011896 
> 
> Diff: http://reviewboard.kde.org/r/1334/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/