[Kde-pim] Review Request: Add borders to Akregator::ArticleViewer

[Frank Osterfeld]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1328/#review2046
-----------------------------------------------------------

Ship it!


Thanks! Applied, Rev. 1012119 (4.3 branch)

IIRC the frame was removed in an attempt to reduce the number of frames in KDE apps, which were considered ugly and distracting back then.
But I agree it looks awkward now without the frame, with oxygen at least, especially in combination with the splitter.


- Frank


On 2009-08-15 17:43:43, Miroslav Los wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1328/
> -----------------------------------------------------------
> 
> (Updated 2009-08-15 17:43:43)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The ArticleViewer in Akregator's main tab does not have any borders. This makes the transition to its container look unclean and the splitter between it and the ArticleListView above it hard to make out and target with the mouse.
> 
> My patch solves this by changing ArticleViewer's base class from QWidget to QFrame and setting its style to Qt::StyledPanel to match the GUI around it and Qt::Raised. I did not select Qt::Sunken because the ArticleView contains the scrollbars of its KHTML component, unlike the sunken ArticleListView next to it. A Qt::Sunken ArticleViewer would therefore break overall UI consistency.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akregator/src/articleviewer.h 1011718 
>   /trunk/KDE/kdepim/akregator/src/articleviewer.cpp 1011718 
> 
> Diff: http://reviewboard.kde.org/r/1328/diff
> 
> 
> Testing
> -------
> 
> Merged and compiled on my 4.3.0 Gentoo machine. Looked and worked much better in all view settings.
> 
> 
> Thanks,
> 
> Miroslav
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/