[Kde-pim] Review Request: Return error when email address ends with '.'

[Tom Albers]

At Thursday 27 August 2009 00:20, you wrote:
> On Wednesday 26 August 2009, Gary Greene wrote:
> > On 8/26/09 11:08 AM, "Martin Koller" <kollix at aon.at> wrote:
> > > On Wednesday 26 August 2009, Torgny Nyblom wrote:
> > >> Check if an email address ends with '.'. If this is the case
> > >> return an error. Add unit tests for this as well as for the
> > >> "isValidAddressList()" function.
> > >
> > > I think it is valid that an email address's domain ends with a "."
> > > Have a look at RFC 1035
> >
> > This is legal according to the RFCs since email clients are supposed
> > to treat this no differently than DNS clients.
> 
> I never came across a domain name ending in '.'. Even if it's valid we 
> should still flag this as an error IMO since it is much more likely 
> that a user accidentally typed a stray '.' than that he really meant to 
> add a trailing '.' to a domain name.

I know there went a lot of time in making that function respect the rfc as close as possible. I dont't think this use case is valid enough to deviate from it. It will bite us.

Best,

Toma
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/