[Kde-pim] Review Request: Instead of negative probability, place the error message that is in the kDebug.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1293/#review2021
-----------------------------------------------------------



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1293/#comment1351>

    I don't like using negative floating points for setting an error status very much.
    Instead, it would be much nicer to make the error reason more explicit by extending the SpamScore to have an enum describing the error.
    That way, magic numbers can be avoided.



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1293/#comment1352>

    coding style: spaces around operators like '=', and inside of parenthesis



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1293/#comment1353>

    I think it is still not a proper sentence :)
    How about sth. like "Error evaluating spam score"?


- Thomas


On 2009-08-13 08:12:00, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1293/
> -----------------------------------------------------------
> 
> (Updated 2009-08-13 08:12:00)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Instead of negative probability, place the error message that is in the kDebug..
> 
> 
> This addresses bug 108255.
>     https://bugs.kde.org/show_bug.cgi?id=108255
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1010470 
> 
> Diff: http://reviewboard.kde.org/r/1293/diff
> 
> 
> Testing
> -------
> 
> changed the spam header and it shows the errors in the tips.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/