[Kde-pim] pgp-auto-sign in kmail composer

[Ingo Klöcker]

On Saturday 01 August 2009, Ingo Klöcker wrote:
> On Saturday 01 August 2009, Martin Koller wrote:
> > On Saturday 01 August 2009, Martin Koller wrote:
> > > Hi,
> > >
> > > I'm trying to check the bug
> > > https://bugs.kde.org/show_bug.cgi?id=51410 dealing with signing.
> > >
> > > Can someone tell me, where in the kmail code the setting for
> > > pgp-auto-sign is actually _used_ ? I can't find it. I only find
> > > ./configuredialog.cpp where it is shown and read/written to the
> > > config file.
> >
> > ok, found it. This is used in kconfig_compiler generated code, and
> > therefore not grep-able in the sources but in the build-dir  ...
> > :-(
>
> You can easily deduce the strings you have to grep for from
> kmail.kcfg.cmake:
>
>       <entry name="PgpAutoSign" type="Bool" key="pgp-auto-sign">
>
> -> the name of the getter will be pgpAutoSign().
[snip]

But I agree that it would be much easier if name and key of the config 
entry were identical. So unless there is a compelling reason (e.g. 
backwards compatibility with old non-KConfigXT config keys) the key 
should always be identical to the name. In fact, key defaults to name 
if it is not explicitly given. So backwards compatibility is probably 
the only acceptable reason for having key != name.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090801/12c7bd49/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/