[Kde-pim] Review Request: Return error when email address ends with '.'

Torgny Nyblom kde at nyblom.org
Wed Aug 26 12:57:12 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1409/
-----------------------------------------------------------

(Updated 2009-08-26 11:57:12.590441)


Review request for KDE PIM.


Summary (updated)
-------

Check if an email address ends with '.'. If this is the case return an error.
Add unit tests for this as well as for the "isValidAddressList()" function.


This addresses bug 139477.
    https://bugs.kde.org/show_bug.cgi?id=139477


Diffs
-----

  /trunk/KDE/kdepimlibs/kpimutils/email.cpp 1015049 
  /trunk/KDE/kdepimlibs/kpimutils/tests/testemail.cpp 1015049 

Diff: http://reviewboard.kde.org/r/1409/diff


Testing
-------

Unit tests work.
Sent email with correct and incorrect (returned error :)) address.


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list