[Kde-pim] decodeRFC2047String

[Martin Koller]

On Monday 24 August 2009, Ingo Klöcker wrote:

> > For the rest of your comments, I understood that there would only be
> > a need for a change if one would change decodeRFC2047(), right ?
> 
> Not really. Using KUrl::fromPercentEncoding() is superfluous in any
> case. So the patch can be reduced to
> -          contents.append( (*it).path() );
> +          contents.append( KMime::decodeRFC2047String(
> (*it).path().toUtf8() ) );

I copied this snippet from kmails stringutil.cpp
Does this mean that its function

QString decodeMailtoUrl( const QString& url )
{
  QString result;
  result = KUrl::fromPercentEncoding( url.toLatin1() );
  result = KMMsgBase::decodeRFC2047String( result.toLatin1() );
  return result;
}

is wrong, too ? And it needs to use toUtf8() also ?

> 
> BTW, discussing the patch would be much easier if it were on Review
> Board (even if it seems to be overkill for such a short patch). ;-)

If the standard KDE browser, konqueror, would be able to deal correctly with 
the reviewboard, I would use it.

BTW: wouldn't is be much simpler in the end if you fix the function ?

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090824/9307153b/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/