[Kde-pim] Review Request: make custom fonts work in message list view

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1249/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

This patch brings back the functionality of using custom defined fonts inside the new message list view on a message-status base.

After a short discussion with the original author of the new message list, Szymon Tomasz Stefanek, I removed all the caching code for fontMetrics, sizeHint, etc. as it did not work with sizeHints per message but per theme and the performance I measured with a mailfolder containing 25900 messages was as good as before.
To me it seems that all the performance improvements which went into the Qt4.5 version solved the problems the original author had to work around while using Qt4.4

The patch also removes the font setting for the date-column from the configure dialog as this is already settable in the theme.

Also, the fonts and colors to be used for a message depending on the status has been slightly modified to match the behavior of KDE3.


This addresses bug 178402.
    https://bugs.kde.org/show_bug.cgi?id=178402


Diffs
-----

  trunk/KDE/kdepim/kmail/configuredialog.cpp 1009321 
  trunk/KDE/kdepim/kmail/configuredialog_p.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/delegate.cpp 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/messageitem.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/model.cpp 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/theme.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/theme.cpp 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/themedelegate.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/themedelegate.cpp 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/core/themeeditor.cpp 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/storagemodel.h 1009321 
  trunk/KDE/kdepim/kmail/messagelistview/storagemodel.cpp 1009321 

Diff: http://reviewboard.kde.org/r/1249/diff


Testing
-------

all different aggregation modes and themes with a mail folder of > 25900 messages (mbox and maildir).


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/