[Kde-pim] Review Request: Split the Groupware tab into two tabs (Groupware & Invitations)

[Thomas McGuire]

> On 2009-08-24 19:56:31, Allen Winter wrote:
> > I really don't like "Misc" for a page name.  we can do better than that.
> > 
> > How about we have  "Folder Settings" page and  "Groupware" page and do away with "Misc" ?
> > 
> > The Groupware page could have 3 tabs: IMAP stuff; Legacy stuff; Inviation stuff
> > 
> > The Folder settings needs re-organizing too.  group trash folder stuff together at least.
> 
> Torgny Nyblom wrote:
>     Agree. What icon should we use for the groupware page?
>     What settings should be counted as "Legacy"?
>     Should all this be in this patch or should it be a followup patch?

I'd say do that as a separate patch.
However, what should be fixed in this patch is that there is a tab "invitations" with a groupbox "invitation options", that just seems superflous.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1393/#review2136
-----------------------------------------------------------


On 2009-08-24 18:22:24, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1393/
> -----------------------------------------------------------
> 
> (Updated 2009-08-24 18:22:24)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move the invitation related options from the groupware tab into a new Invitations tab.
> Reduces the minimum size of the configuration dialog.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/ui/miscpageinvitetab.ui PRE-CREATION 
>   /trunk/KDE/kdepim/kmail/configuredialog_p.h 1015049 
>   /trunk/KDE/kdepim/kmail/ui/miscpagegroupwaretab.ui 1015049 
>   /trunk/KDE/kdepim/kmail/CMakeLists.txt 1015049 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1015049 
> 
> Diff: http://reviewboard.kde.org/r/1393/diff
> 
> 
> Testing
> -------
> 
> Compiles against trunk,
> All settings are saved and restored.
> 
> 
> Screenshots
> -----------
> 
> Groupwaretab
>   http://reviewboard.kde.org/r/1393/s/188/
> Invitationstab
>   http://reviewboard.kde.org/r/1393/s/189/
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/