[Kde-pim] Review Request: show only default address in 'Select recipient' dialog

Thomas McGuire mcguire at kde.org
Wed Aug 5 22:10:30 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1181/#review1907
-----------------------------------------------------------

Ship it!


Ok, seems fine, please commit.
Thanks :)

Indeed the default for the column sizes could be better, so that they fit into the default window size, but that is for another commit.

- Thomas


On 2009-08-04 23:35:29, Bruno Bigras wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1181/
> -----------------------------------------------------------
> 
> (Updated 2009-08-04 23:35:29)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Group emails by contact showing the default address in the "Select Recipient" dialog. Based on a commit by Christian Schaarschmidt on the 3.5.5+ branch. (see: https://bugs.kde.org/show_bug.cgi?id=131796#c2 )
> 
> Like the original commit, the "->" column is now the last one to make room for the tree navigation thing. The column is not visible with the default window size, maybe it should be changed.
> 
> 
> This addresses bug 131796.
>     https://bugs.kde.org/show_bug.cgi?id=131796
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/recipientspicker.h 1006953 
>   /trunk/KDE/kdepim/kmail/recipientspicker.cpp 1006953 
> 
> Diff: http://reviewboard.kde.org/r/1181/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/1181/s/156/
> 
>   http://reviewboard.kde.org/r/1181/s/157/
> 
> 
> Thanks,
> 
> Bruno
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list