[Kde-pim] Review Request: Return error when email address ends with '.'

[Torgny Nyblom]

On Thursday 27 August 2009 20.13.46 Ingo Klöcker wrote:
> On Thursday 27 August 2009, Gary L. Greene, Jr. wrote:
> > On Wednesday 26 August 2009 10:17:35 pm Torgny Nyblom wrote:
> > > On Wednesday 26 August 2009 20:33:09 you wrote:
> > > > On 8/26/09 11:08 AM, "Martin Koller" <kollix at aon.at> wrote:
> > > > > On Wednesday 26 August 2009, Torgny Nyblom wrote:
> > > > >> Check if an email address ends with '.'. If this is the case
> > > > >> return an error. Add unit tests for this as well as for the
> > > > >> "isValidAddressList()" function.
> > > > >
> > > > > I think it is valid that an email address's domain ends with a
> > > > > "." Have a look at RFC 1035
> > > >
> > > > This is legal according to the RFCs since email clients are
> > > > supposed to treat this no differently than DNS clients.
> > >
> > > I've been looking at that RFC but I cannot find were it says that
> > > "user at domain.tld." should be a vaild email address. Could you point
> > > me to where this is specified?
> >
> > As this is defined in RFC 3696,
> > http://tools.ietf.org/html/rfc3696#page-5 , The domain portion must
> > be a valid domain address that is understood by DNS for the express
> > purpose of discovering the MX for a given network. These are of
> > course defined in RFC 1035 that the trailing . is legal.
> 
> In fact, the trailing period is not just legal, it even has a special
> semantic.
> 
> RFC 3696, section 2 (Restrictions on domain (DNS) names) reads
>    [...] The DNS specification also
>    permits a trailing period to be used to denote the root, e.g.,
>    "a.b.c" and "a.b.c." are equivalent, but the latter is more explicit
>    and is required to be accepted by applications. [...]
> 
> (cf. http://tools.ietf.org/html/rfc3696#page-4)
> 
> 
> So, the change should be reverted/rejected.

Already done, Guess the correct fix is to fix the code that trunkates the To: 
line on trailing ".".

/regards
Torgny
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/