[Kde-pim] Review Request: Enable AutoFormatting in knotes only if rich text is enabled (bug #203321)

FiNeX finex at finex.org
Fri Aug 21 09:53:27 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1380/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Currently knotes uses QTextEdit::AutoAll. When an user press "-" or "*" automatically it creates a bullet list. It should be disabled when the rich text mode is off.

This small patch enable/disable auto formatting according to the settings of rich text option.


This addresses bug 203321.
    https://bugs.kde.org/show_bug.cgi?id=203321


Diffs
-----

  /trunk/KDE/kdepim/knotes/knoteedit.cpp 1013250 

Diff: http://reviewboard.kde.org/r/1380/diff


Testing
-------

I've applied the patch on trunk and I've tried to:
1) start knotes
2) edit some text with the "rich text off" option: the bullet list is not added  [OK]
3) enable rich text
4) try to edit the text again, the auto formatting has been enabled too  [OK]
5) restart knotes and try to edit text, auto formatting is still enabled [OK]
6) disable rich text
7) input some other text, auto formatting is disabled [OK]


Thanks,

FiNeX

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list