[Kde-pim] Review Request: Make Monitor report what it is monitoring.

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/492/#review773
-----------------------------------------------------------


Just two minor issues: Collection/Item parameters should be passed as const references and some API docs would be nice, as this is public API.

- Volker


On 2009-04-01 04:00:57, Stephen Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/492/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 04:00:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Adds a way to query Monitor for what it is monitoring and makes it emit signals when that changes.
> 
> I don't like the name of the isAllMonitored signal particularly and I'd welcome suggestions for better names.
> 
> 
> Diffs
> -----
> 
>   KDE/kdepimlibs/akonadi/monitor.h 940054 
>   KDE/kdepimlibs/akonadi/monitor.cpp 940054 
> 
> Diff: http://reviewboard.kde.org/r/492/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stephen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/