[Kde-pim] Review Request: Add Geo tag support and fix the multihash problem

Csaba Kertész csaba.kertesz at nokia.com
Wed Apr 1 12:27:03 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/495/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The patch solves two situation:

1. It adds support for the Geo field of the iCalendar which was missing so far.
2. Event/note start/end time changes caused duplicates in the CalendarLocal hashes. The bug is easy to detect by
patching only tests/testcalendarlocal.cpp (and .h) and trying the new test with old KCal.


Diffs
-----

  trunk/KDE/kdepimlibs/kcal/alarm.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.h 947746 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/event.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/freebusy.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/incidence.h 947746 
  trunk/KDE/kdepimlibs/kcal/incidence.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/incidencebase.h 947746 
  trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.h 947746 
  trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.cpp 947746 
  trunk/KDE/kdepimlibs/kcal/todo.cpp 947746 

Diff: http://reviewboard.kde.org/r/495/diff


Testing
-------

Written unit test case to verify the fix.


Thanks,

Csaba

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list