[Kde-pim] Review Request: Make cyrus-sasl a required dependency and clean the code

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/595/#review934
-----------------------------------------------------------


looks fine, except for the minor stuff I mention in my comments.


/trunk/KDE/kdepimlibs/CMakeLists.txt
<http://reviewboard.kde.org/r/595/#comment625>

    don't put the REQUIRED here.  the macro_display_log() will quit for you since macrog_log_feature() is told that SASL2_FOUND must be set 



/trunk/KDE/kdepimlibs/akonadi/tests/itemdeletetest.cpp
<http://reviewboard.kde.org/r/595/#comment624>

    I don't think this change is related to this patch, is it?



/trunk/KDE/kdepimlibs/akonadi/tests/testrunner/CMakeLists.txt
<http://reviewboard.kde.org/r/595/#comment623>

    does removing this line have anything to do with this patch?


- Allen


On 2009-04-15 11:11:55, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/595/
> -----------------------------------------------------------
> 
> (Updated 2009-04-15 11:11:55)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Cyrus-SASL is needed for a large number of authentication types in the IMAP/POP3 kioslaves and the new KIMAP library. Previously it was optional, but KIMAP has a hard dependency on it, therefor the whole kdepimlibs have it, so it doesn't make sense to keep the optionality in other code inside kdepimlibs. The reasoning for making it a hard dependency is that not having cyrus-sasl would make our PIM apps incompatible with some server installations anyway, and we want to avoid mistakes like distributions compiling kdepimlibs without the cyrus-sasl installed, resulting in "broken" applications for the user.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/CMakeLists.txt 954184 
>   /trunk/KDE/kdepimlibs/ConfigureChecks.cmake 954184 
>   /trunk/KDE/kdepimlibs/akonadi/tests/itemdeletetest.cpp 954184 
>   /trunk/KDE/kdepimlibs/akonadi/tests/testrunner/CMakeLists.txt 954184 
>   /trunk/KDE/kdepimlibs/kimap/loginjob.cpp 954184 
>   /trunk/KDE/kdepimlibs/kioslave/CMakeLists.txt 954184 
>   /trunk/KDE/kdepimlibs/kioslave/common.h 954184 
>   /trunk/KDE/kdepimlibs/kioslave/imap4/imap4.cpp 954184 
>   /trunk/KDE/kdepimlibs/kioslave/imap4/imapparser.cpp 954184 
>   /trunk/KDE/kdepimlibs/kioslave/pop3/pop3.cpp 954184 
>   /trunk/KDE/kdepimlibs/kioslave/smtp/command.h 954184 
>   /trunk/KDE/kdepimlibs/kioslave/smtp/command.cpp 954184 
>   /trunk/KDE/kdepimlibs/kioslave/smtp/smtp.cpp 954184 
> 
> Diff: http://reviewboard.kde.org/r/595/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/