[Kde-pim] Review Request: Have KMail behave more like other kdepim apps with regards to session management/systray

[Mathieu Seigneurin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/504/
-----------------------------------------------------------

(Updated 2009-04-04 04:07:39.519277)


Review request for KDE PIM.


Changes
-------

Third attempt, sorry for the noise.
After having fiddled around, I believe this might actually be closer to an acceptable way of doing the restore to tray.
Added comments to explain what is going on, code change is actually really minor.


Summary
-------

Hello,
With this patch, KMail should start minimized to tray on session open if it was minimized to tray on session close.
This makes it more consistent with e.g. aKregator (patch base entirely on aKregator) and might help close bug 75673.

Please be gentle - this is my first patch/review :-)


This addresses bug 75673.
    https://bugs.kde.org/show_bug.cgi?id=75673


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmmainwin.h 949028 
  /trunk/KDE/kdepim/kmail/kmmainwin.cpp 949028 

Diff: http://reviewboard.kde.org/r/504/diff


Testing
-------

Works for me on KDE 4.2.2 (gentoo). No idea if/how a testcase can be written.


Thanks,

Mathieu

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/