[Kde-pim] Review Request: Have KMail behave more like other kdepim apps with regards to session management/systray

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/504/#review876
-----------------------------------------------------------

Ship it!


Ah, you are right, I forgot about API compatibility. So I'll simply commit you patch to KMail, and will add a TODO to the kdelibs class for KDE 5, when we can change it.

You can see more details about binary compatibility here: http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++
Removing an argument is not even source compatible.

So I'll commit. Please close the review request as submitted.
Thank you for the patch!

- Thomas


On 2009-04-04 04:07:39, Mathieu Seigneurin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/504/
> -----------------------------------------------------------
> 
> (Updated 2009-04-04 04:07:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Hello,
> With this patch, KMail should start minimized to tray on session open if it was minimized to tray on session close.
> This makes it more consistent with e.g. aKregator (patch base entirely on aKregator) and might help close bug 75673.
> 
> Please be gentle - this is my first patch/review :-)
> 
> 
> This addresses bug 75673.
>     https://bugs.kde.org/show_bug.cgi?id=75673
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwin.h 949028 
>   /trunk/KDE/kdepim/kmail/kmmainwin.cpp 949028 
> 
> Diff: http://reviewboard.kde.org/r/504/diff
> 
> 
> Testing
> -------
> 
> Works for me on KDE 4.2.2 (gentoo). No idea if/how a testcase can be written.
> 
> 
> Thanks,
> 
> Mathieu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/