[Kde-pim] Review Request: Add Geo tag support and fix the multihash problem

[Kevin Krammer]

> On 2009-04-18 06:25:54, Sergio Martins wrote:
> > trunk/KDE/kdepimlibs/kcal/incidence.h, line 733
> > <http://reviewboard.kde.org/r/495/diff/1/?file=4630#file4630line733>
> >
> >     returning a float by reference can be slower than returning it by value i think

Indendent of performance, a const method should not return a non-const handle (reference, pointer).
Actually a static code analyzer we use at work regard publically returning handles to non-public members a severe violation


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/495/#review956
-----------------------------------------------------------


On 2009-04-01 04:27:03, Csaba Kertész wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/495/
> -----------------------------------------------------------
> 
> (Updated 2009-04-01 04:27:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The patch solves two situation:
> 
> 1. It adds support for the Geo field of the iCalendar which was missing so far.
> 2. Event/note start/end time changes caused duplicates in the CalendarLocal hashes. The bug is easy to detect by
> patching only tests/testcalendarlocal.cpp (and .h) and trying the new test with old KCal.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/alarm.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.h 947746 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/event.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/freebusy.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/incidence.h 947746 
>   trunk/KDE/kdepimlibs/kcal/incidence.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.h 947746 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.h 947746 
>   trunk/KDE/kdepimlibs/kcal/tests/testcalendarlocal.cpp 947746 
>   trunk/KDE/kdepimlibs/kcal/todo.cpp 947746 
> 
> Diff: http://reviewboard.kde.org/r/495/diff
> 
> 
> Testing
> -------
> 
> Written unit test case to verify the fix.
> 
> 
> Thanks,
> 
> Csaba
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/