[Kde-pim] Review Request: View mail source with all headers in bold.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/636/#review999
-----------------------------------------------------------

Ship it!


Looks nice, thanks for the patch.
I've added some minor issues below, fixing them would make for more readable code.


trunk/KDE/kdepim/kmail/mailsourceviewer.cpp
<http://reviewboard.kde.org/r/636/#comment680>

    A small comment explaining that a Content- header starts a new mime part, and therefore new headers, would be nice



trunk/KDE/kdepim/kmail/mailsourceviewer.cpp
<http://reviewboard.kde.org/r/636/#comment681>

    Instead of -1 and 0, I would prefer some const ints with descriptive names here, to make the code more readable



trunk/KDE/kdepim/kmail/mailsourceviewer.cpp
<http://reviewboard.kde.org/r/636/#comment679>

    typo here


- Thomas


On 2009-04-28 03:39:19, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/636/
> -----------------------------------------------------------
> 
> (Updated 2009-04-28 03:39:19)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Use the right regular expresion to check for mail headers.
> Also, use a mini ad-hoc state machine to not treat all that look headers as headers.
> When a blank line is found, it is supposed to start a body part, until a header with Content- is found.
> 
> 
> This addresses bugs 88271 and 152707.
>     https://bugs.kde.org/show_bug.cgi?id=88271
>     https://bugs.kde.org/show_bug.cgi?id=152707
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/mailsourceviewer.cpp 959600 
> 
> Diff: http://reviewboard.kde.org/r/636/diff
> 
> 
> Testing
> -------
> 
> Seen the bugs attached mails and others.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/