[Kde-pim] Review Request: Fixes the bug 182208: Spam filtering on IMAP is possible again!

Mon Apr 6 16:08:52 BST 2009

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/369/
-----------------------------------------------------------

(Updated 2009-04-06 08:08:51.864762)

Review request for KDE PIM.

Summary
-------

Fixes the bug 182208: (Spam filtering on IMAP is possible again!)

Filtering would stall forever with ActionScheduler (=whenever you use imap) on "Pipe Through" action.
Manually executing a filter from menu/toolbar would not use ActionScheduler, even if you use imap.
Manually executing a filter from menu/toolbar will not execute it, if "Apply this fitler to incoming Messages" and "Apply this filter to sent messages" and "Apply this filter on manual processing" are all false.
"Pipe through" of ActionScheduler now keeps "X-UID"-field for message identification, just as KMFilter implementation does.

P.S.: Is someone maintaining the actionScheduler? It seems far more complicated than it should and I would really like to clean it up a bit.

This addresses bugs 171061, 174430, 182208, and 186264.
    https://bugs.kde.org/show_bug.cgi?id=171061
    https://bugs.kde.org/show_bug.cgi?id=174430
    https://bugs.kde.org/show_bug.cgi?id=182208
    https://bugs.kde.org/show_bug.cgi?id=186264

Diffs
-----

  trunk/KDE/kdepim/kmail/actionscheduler.h 948237 
  trunk/KDE/kdepim/kmail/actionscheduler.cpp 948237 
  trunk/KDE/kdepim/kmail/kmcommands.cpp 948237 
  trunk/KDE/kdepim/kmail/kmfilteraction.cpp 948237 

Diff: http://reviewboard.kde.org/r/369/diff

Testing
-------

Thanks,

Matthias

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/