[Kde-pim] Review Request: Paste URLs in KMail as attachments

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/519/#review870
-----------------------------------------------------------

Ship it!


Thanks for the patch, please commit (and add const to urlList before commiting).


/trunk/KDE/kdepim/kmail/kmcomposereditor.cpp
<http://reviewboard.kde.org/r/519/#comment547>

    looks like urlList can be const here.


- Thomas


On 2009-04-04 10:14:57, Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/519/
> -----------------------------------------------------------
> 
> (Updated 2009-04-04 10:14:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When pasting URLs in KMail add them as attachment.
> This makes the behavior consistent with dropping files.
> I'm not sure if this should check if the file is local and only then attach?
> 
> 
> This addresses bug 188313.
>     https://bugs.kde.org/show_bug.cgi?id=188313
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmcomposereditor.cpp 949105 
> 
> Diff: http://reviewboard.kde.org/r/519/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/