[Kde-pim] Review Request: KAddressBook: when filtering, use all values a named field can have

Tobias Koenig tokoe at kde.org
Fri Apr 3 20:43:04 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/487/#review810
-----------------------------------------------------------

Ship it!


Looks good.

- Tobias


On 2009-03-31 12:54:45, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2009-03-31 12:54:45)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Similar to one of my earlier requests (discarded).
> This time a change to just KAddressBook code, which means it can be ported with little change to 4.2 branch.
> 
> Some fields (as in KABC::Field) can have more than one value, e.g. an addressee having more than one mobile phone number.
> 
> 
> This addresses bug 187499.
>     https://bugs.kde.org/show_bug.cgi?id=187499
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kaddressbook/searchmanager.cpp 947576 
> 
> Diff: http://reviewboard.kde.org/r/487/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list