[Kde-pim] Review Request: KResource Bridges: use explizit threading to run blocking jobs

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/522/#review818
-----------------------------------------------------------

Ship it!


Looks good to me.

- Volker


On 2009-04-04 12:31:47, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/522/
> -----------------------------------------------------------
> 
> (Updated 2009-04-04 12:31:47)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> As the bug report shows, using QtConcurrent::run() is unfortunately not a solution for your problem, since it can run the job in the calling thread instead of a separate worker thread.
> 
> Therefore I switched the code to explicit threading.
> 
> 
> This addresses bug 188058.
>     https://bugs.kde.org/show_bug.cgi?id=188058
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/akonadi/shared/concurrentjobs.cpp 949264 
>   /trunk/KDE/kdepim/kresources/akonadi/shared/concurrentjobs.h 949264 
> 
> Diff: http://reviewboard.kde.org/r/522/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/