[Kde-pim] Review Request: Have KMail behave more like other kdepim apps with regards to session management/systray

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/504/#review871
-----------------------------------------------------------


The approach is good, but wouldn't it make more sense to add this to KMainWin in kdelibs instead, so that all apps can profit from this?

BTW, sorry for the late review, I was away.

- Thomas


On 2009-04-04 04:07:39, Mathieu Seigneurin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/504/
> -----------------------------------------------------------
> 
> (Updated 2009-04-04 04:07:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Hello,
> With this patch, KMail should start minimized to tray on session open if it was minimized to tray on session close.
> This makes it more consistent with e.g. aKregator (patch base entirely on aKregator) and might help close bug 75673.
> 
> Please be gentle - this is my first patch/review :-)
> 
> 
> This addresses bug 75673.
>     https://bugs.kde.org/show_bug.cgi?id=75673
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwin.h 949028 
>   /trunk/KDE/kdepim/kmail/kmmainwin.cpp 949028 
> 
> Diff: http://reviewboard.kde.org/r/504/diff
> 
> 
> Testing
> -------
> 
> Works for me on KDE 4.2.2 (gentoo). No idea if/how a testcase can be written.
> 
> 
> Thanks,
> 
> Mathieu
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/