[Kde-pim] [patch] korganizer - printing calendar item recurrence

[Allen Winter]

On Sunday 31 August 2008 18:10:00 Allen Winter wrote:
> On Sunday 31 August 2008 11:00:15 Ron Goodheart wrote:
> >
> > Thanks for all the feedback! Another stab at recurrence printing code...
> > 
> > I've attached the modified diffs for korganizer printing 3.5 and trunk
> > with corrections and information for the translators.
> > I tried to make abundantly clear the usage of the parameters and moved
> > out singular/plural constructs into i18np() calls. I will be glad to
> > revise if I went overboard on this.
> > 
> > Additionally, I did have some difficulty with linking
> > libkorg_stdprinting.so due to including
> > "KOGlobals::self()->calendarSystem();" which was needed for some of
> > the date formatting. This was solved by changing the linking to STATIC
> > (diff attached) - perhaps there is a better way to do this?
> > 
> > attached are three diffs:
> > 1) changes to 3.5 - recurrence print code
> > 2) changes to trunk - recurrence print code
> > 3) changes to trunk - static linking of libkorg_stdprinting
> > 
> Ron,
> Wow, nice.
> I'll take a closer look at the trunk version within the next few days.
> 
Ah, the problem with the linking... there is a cyclic dependency.
The korganizerprivate library links to the korg_stdprinting, but
you need to link korg_stdprinting back to korganizerprivate
to use KOGlobals.

We get around this by calling the KCalendarSystem directly
instead of using KOGlobals::calendarSystem().

Yes, this is wrong and we should do the "right thing".
For the time being, I will use the same trick.  So we
can get your work committed.

Oh, and I'd like to add your copyright.  Should I use your gmail.com
email address for the copyright, or do you want some other address?

-Allen
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/