[Kde-pim] KDE/kdepimlibs/kcal

[David Jarvie]

On Tuesday 9 September 2008 6:03, Thorsten Staerk wrote:
> SVN commit 858920 by tstaerk:
>
> In kmail invitations, show the meeting time in the local time zone.
> BUGS:170512
> CCMAIL:kde-pim at kde.org
> --Thiline, and those below, will be ignored--
>
> M    kcal/icalformat.cpp
>
>
>  M  +1 -0      icalformat.cpp
>
>
> --- trunk/KDE/kdepimlibs/kcal/icalformat.cpp #858919:858920
> @@ -580,6 +580,7 @@
>
>    icalcomponent_free( message );
>    icalcomponent_free( calendarComponent );
> +  incidence->shiftTimes( cal->timeSpec(), KDateTime::Spec::LocalZone() );
>    return new ScheduleMessage( incidence, method, status );
>  }

I don't know enough about the use of ScheduleMessage to know whether this
commit is correct or not, but I feel uneasy about this use of
shiftTimes(). The main question is whether the ScheduleMessage instance
returned can ever be written back into a calendar file (remembering that
other applications than KMail may use this method, e.g. KOrganizer). If it
can be written to a calendar file (as seems very likely), it is likely to
produce unwanted errors.

In particular, if the incidence can contain a recurrence, then it is
almost certainly the wrong thing to do, since changing the time zone for
some recurrences can have unpredictable effects on the times that the
occurrences are scheduled for, due to seasonal time changes.

If my doubts are valid, then the change should be reverted and the time
correction should be made in the display code, not in the incidence data
itself.

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/