[Kde-pim] [patch] Drag and drop of attachments from non-KDE apps, including Windows

[Ingo Klöcker]

On Thursday 29 May 2008, Jarosław Staniek wrote:
> For review:
> Drag and drop of attachements from non-KDE apps, including Windows
>
> Also refactored the event handlers a bit.

I don't like the duplication of the accepted status by having 
handleDragEvent() call e->accept() and return true if the event is 
accepted. This is guaranteed to lead to inconsistencies. I suggest to 
get rid of the bool return value and write

+void KMeditor::dragEnterEvent( QDragEnterEvent *e )
+{
+  handleDragEvent( e );
+  if ( ! e->isAccepted() )
+    KTextEdit::dragEnterEvent( e );
+}

and similar for KMeditor::dragMoveEvent().


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080529/ec4506e6/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/