[Kde-pim] [patch] handling of static data in akonadi and mailtransport

[Jaroslaw Staniek]

Thomas McGuire said the following, On 2008-05-20 22:16:
> Hi,
> 
> On Tuesday 20 May 2008, Jarosław Staniek wrote:
>> the patch
> 
> No need for static void cleanup(), you can simplify that by writing 
> qAddPostRoutine( sSelf.destroy ).

done

> I'm not sure if the qAddPostRoutine() hack is needed (the difference is only 
> that the object is destroyed when QCoreApplication is deleted, not when the 
> library unloads), but it is probably better to be safe than sorry.

For library it's better to have post routine set up.
BTW qAddPostRoutine is mentioned here: 
http://techbase.kde.org/Development/Tutorials/Common_Programming_Mistakes#Static_variables

> Other than that and Ingo's comments, the mailtransport changes seem fine, 
> although I would use class SlavePool instead of struct SlavePool, since a 
> struct with functions is a bit weird (although you already removed much 
> weirdness from mailtransport:)

Thx, commited: rev 810888, 810890, 810891.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/